Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump doctrine/dbal from 2.9.2 to 2.10.2 #21208

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Bump doctrine/dbal from 2.9.2 to 2.10.2 #21208

merged 2 commits into from
Jun 9, 2020

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jun 3, 2020 •
edited
Loading

For #16876

After ages this will pull in my upstream patch doctrine/dbal#3843

@ChristophWurst ChristophWurst added this to the Nextcloud 20 milestone Jun 3, 2020
@ChristophWurst ChristophWurst self-assigned this Jun 3, 2020
yarons
yarons approved these changes Jun 3, 2020
View reviewed changes
Copy link

@yarons yarons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know what to do but I approve.

@ChristophWurst ChristophWurst force-pushed the dependabot/composer/doctrine/dbal-2.10.2 branch from fd5b15d to 18bea3f Compare June 4, 2020 07:42
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 4, 2020
@gary-kim gary-kim mentioned this pull request Jun 5, 2020
Closed
@rullzer
Copy link
Member

rullzer commented Jun 5, 2020

CI says no https://drone.nextcloud.com/nextcloud/server/29482/10/4

@nickvergessen
Copy link
Member

Fix is in nextcloud/3rdparty#452

@nickvergessen nickvergessen added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jun 5, 2020
@ChristophWurst
Bump doctrine/dbal from 2.9.2 to 2.10.2
3151945 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the dependabot/composer/doctrine/dbal-2.10.2 branch from c7bc914 to 3151945 Compare June 5, 2020 09:48
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 5, 2020
@ChristophWurst
Copy link
Member Author

Fixed. Thanks a lot.

@nickvergessen
Copy link
Member

There were 8 failures:

Fun!

@nickvergessen nickvergessen mentioned this pull request Jun 8, 2020
Closed
@nickvergessen
Remove dropped " ON " when join has no condition
c68718f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

Fixed

@ChristophWurst
Copy link
Member Author

CI is not fully done but looks promising 🙏

@rullzer rullzer merged commit de35da3 into master Jun 9, 2020
@rullzer rullzer deleted the dependabot/composer/doctrine/dbal-2.10.2 branch June 9, 2020 09:08
@ChristophWurst ChristophWurst mentioned this pull request Jun 9, 2020
Closed
@MorrisJobke MorrisJobke mentioned this pull request Aug 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@yarons yarons yarons approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@kesselb kesselb Awaiting requested review from kesselb

@lihuabao lihuabao Awaiting requested review from lihuabao

@Grotax Grotax Awaiting requested review from Grotax

@richardhj richardhj Awaiting requested review from richardhj

@danjpgriffin danjpgriffin Awaiting requested review from danjpgriffin

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews feature: dependencies
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @rullzer @nickvergessen @yarons